Nack!
This won't work as the dasd object currently is not a singleton. To
make it a singleton using the same design pattern as iscsi / zfcp / fcoe
add:
# So that users can write DASD() to get the singleton instance
def __call__(self):
return self
To the DASD class, and the following to the end of dasd.py:
# Create DASD singleton
DASD = DASD()
Regards,
Hans
On 04/14/2010 07:02 PM, David Cantrell wrote:
In the storage filtering UI, we need to call the startup() method of
storage.dasd.DASD so it will check for unformatted DASD devices and
offer the user the ability to format them.
---
iw/filter_gui.py | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/iw/filter_gui.py b/iw/filter_gui.py
index 64b8700..63c834e 100644
--- a/iw/filter_gui.py
+++ b/iw/filter_gui.py
@@ -35,6 +35,7 @@ from flags import flags
import storage.iscsi
import storage.fcoe
import storage.zfcp
+import storage.dasd
import gettext
_ = lambda x: gettext.ldgettext("anaconda", x)
@@ -550,8 +551,7 @@ class FilterWindow(InstallWindow):
storage.iscsi.iscsi().startup(anaconda.intf)
storage.fcoe.fcoe().startup(anaconda.intf)
storage.zfcp.ZFCP().startup()
- # Note we do NOT call dasd.startup() here, that does not online drives,
- # but only checks if they need formatting.
+ storage.dasd.DASD().startup(anaconda.intf)
disks = filter(udev_device_is_disk, udev_get_block_devices())
(singlepaths, mpaths, partitions) = identifyMultipaths(disks)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
