> commit 8e62952a0e52d9ac5df781eb2f4ff5915208602b causes a number of > issues for biosraid / mpath: > 1) For biosraid it passes the raidset name to _active, but _active > expects a udev info dict now > 2) _active now takes the name to compare to exclusivedisks from the passed > udev info dict, but for biosraid and mpath the name stored in exclusiveDisks > is not the member udev name, but the name of the higher level device > (Note the code before the above commit already got this wrong for the > mpath case) > > This patch fixes this by: > 1) Passing the fake udev info data for biosraid sets to _active and > to _isProtected (it adds a sysfs_path entry to the fake data for this). > This fixes both above problems for biosraid > 2) Creating fake udev info data for mpath, setting the name of that > to the name of the higher level device and using that as _Active > and _isProtected argument. By also storing this info dict into to > store, we can can also drop the special mpath case in getNext() > > Note 1: This also fixes the miss merge of commit > 8e62952a0e52d9ac5df781eb2f4ff5915208602b on F-13 branch, fixing #581820 > > Note 2: This depends on also cherry picking > 6a289692b304c8423cfebca16faedfd8feab8b44 to F-13 branch Looks okay, though I'd really like to see a longer commit message next time. - Chris _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
