On 04/12/2010 02:28 PM, Peter Jones wrote:
> On 04/12/2010 03:57 AM, Ales Kozumplik wrote:
>> ---
>> storage/devices.py | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/storage/devices.py b/storage/devices.py
>> index 387c4b4..03d143a 100644
>> --- a/storage/devices.py
>> +++ b/storage/devices.py
>> @@ -3106,7 +3106,8 @@ class MultipathDevice(DMDevice):
>> rc = iutil.execWithRedirect("multipath",
>> [self.name],
>> stdout = "/dev/tty5",
>> - stderr = "/dev/tty5")
>> + stderr = "/dev/tty5",
>> + searchPath = 1)
>> if rc:
>> raise MPathError("multipath activation failed for '%s'" %
>> self.name)
>
> So, ACK on this, but we also need to do it elsewhere.
>
On second thought:
<pjones> dlehman: so the question is: should we really do ales's patch and the one I just sent, or should we just fix execWithRedirect not to care?
<dlehman> pjones: you mean remove searchPath or just that little check from chroot?
<pjones> either or both?
<dlehman> yeah. I doubt there's decent error propagation if we only remove the latter
<pjones> (I'd really prefer "error if you specify a full path because we shouldn't be doing that" plus "always search $PATH for everything")
<dlehman> that's what I'd like as well
<dlehman> or at least log a warning if a full path it specified
--> sandeen` (~sandeen@nat/redhat/x-gyuhelaeorozeiku) has joined #anaconda
<pjones> if command.startswith('/'): log.warning("full path specified for %s" % (command,))
<pjones> ( if command.startswith('/'): log.warning("$COMMITTER is an asshole.") ;)
<dlehman> that'll work
searchPath-ectomy coming soon...
--
Peter
All parts should go together without forcing. You must remember that
the parts you are reassembling were disassembled by you. Therefore,
if you can't get them together again, there must be a reason. By all
means, do not use a hammer.
-- IBM maintenance manual, 1925
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
