Re: [PATCH] [RHEL-6] Don't make UEFI boot media for i386 (576580)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/31/2010 07:35 PM, David Cantrell wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Wed, 31 Mar 2010, Peter Jones wrote:
> 
>> We're not supporting UEFI on non-64-bit x86 machines in RHEL-6, so don't
>> make media that tries to support that. This patch also conditionalizes
>> the use of UEFI on boot.iso, and turns it off so that boot.iso can be
>> used as a fallback since disc1 is UEFI enabled.
>> ---
>> scripts/mk-images     |    5 ++++-
>> scripts/mk-images.x86 |    3 ++-
>> 2 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/mk-images b/scripts/mk-images
>> index 9e5a94d..329389d 100755
>> --- a/scripts/mk-images
>> +++ b/scripts/mk-images
>> @@ -1007,9 +1007,12 @@ if [ ${BUILDARCH} = s390x ]; then
>> elif [ ${BUILDARCH} = ppc64 ]; then
>>     # ... and similar for ppc64
>>     source $TOPDIR/mk-images.ppc
>> -elif [ ${BUILDARCH} = "x86_64" -o ${BUILDARCH} = "i386" ]; then
>> +elif [ ${BUILDARCH} = "x86_64" ]; then
>> +    export UEFI_BOOT_ISO="no"
> 
> Shouldn't this be:
> export UEFI_BOOT_ISO="yes"
> 
> Per the patch comment and the test below?

Maybe I should revise the comment some to make it more clear - we're not
making anything UEFI bootable on i386, because we're not supporting that, and
we're turning off boot.iso being UEFI bootable on /x86_64/, so it can be used
as a fallback if you've got hardware that you're trying to install a
BIOS-booted OS on, but on which that won't work for whatever reason if the CD
has UEFI boot info.

-- 
        Peter

What we need is either less corruption, or more chances to
participate in it.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux