-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/30/2010 12:37 AM, Ales Kozumplik wrote: > On 03/30/2010 02:01 AM, Brian C. Lane wrote: >>> + # vtActivate() might fail on certain ppc64 machines >>> + try: >>> + isys.vtActivate(1) >>> + except SystemError: >>> + pass >>> sys.exit(1) >>> else: >>> storage.reset() >> >> This would be cleaner if you used the iutil.abnormal_exit(self.exitcode) >> method you added in the other patch > > That's right, but this is f13 so I don't want to make big changes. Or do > you mean to introduce the method and just use it this one place? > I'd add the new method, and then only use it in this one place for the f13 branch. That way it is in place, and for f13 you just need to re-factor all the vtActive calls. - -- Brian C. Lane <bcl@xxxxxxxxxx> Red Hat / Port Orchard, WA -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEVAwUBS7IdsBF+jBaO/jp/AQKE5AgAlFsgVjppJaJWe197kbhKg/jMn5bMi7ad g3DA59zqBwPUpIu7cODu1E9cLC6W8eneelMVqzqwwMylBF4d/Y78rhnYR0+L5F3Q G/GrXnlJPbz0NyoY89OIUkXjT9cDXMmoJSXxqfCVTidy2WSMENa+c6384CDSDof+ 7BGcScpIPtFghSGK4wBXi26IntH7zKxfTRb2sKUBNE8vNZ89ilEKvuwY6A8dxRFQ b4Eo8yXIHiWDvH2G5cu2LcaWqBSbapBqUh/L+3+e25lP0CkSgJpG1vLo0bd1PcLc SV9eMS73DXBC9AVc9mNHJNg96BcplqhYqkSvEhl1IUGvfnIliGhbVw== =hwBa -----END PGP SIGNATURE----- _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
