[PATCH 1/2] Remove stderr fprintf's from library functions (#576251)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Library functions should not be printing anything. I did leave them in
printMD5SUM because it's purpose is to print the MD5 sum.
---
 libcheckisomd5.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/libcheckisomd5.c b/libcheckisomd5.c
index 138438b..44dfc49 100644
--- a/libcheckisomd5.c
+++ b/libcheckisomd5.c
@@ -221,7 +221,6 @@ static int checkmd5sum(int isofd, char *mediasum, char *computedsum, checkCallba
 	    break;
 
         if (nread > nattempt) {
-            fprintf(stderr, "Warning: read got more data than requested\n");
             nread = nattempt;
             lseek(isofd, offset+nread, SEEK_SET);
         }
@@ -304,10 +303,6 @@ static int doMediaCheck(int isofd, char *mediasum, char *computedsum, long long
     char fragmentsums[FRAGMENT_SUM_LENGTH+1];
 
     if (parsepvd(isofd, mediasum, &skipsectors, isosize, supported, fragmentsums, &fragmentcount) < 0) {
-	fprintf(stderr, "Unable to read the disc checksum from the "
-			 "primary volume descriptor.\nThis probably "
-			 "means the disc was created without adding the "
-			 "checksum.");
 	return ISOMD5SUM_CHECK_NOT_FOUND;
     }
 
@@ -326,7 +321,6 @@ int mediaCheckFile(char *file, checkCallback cb, void *cbdata) {
     isofd = open(file, O_RDONLY);
 
     if (isofd < 0) {
-	fprintf(stderr, "Unable to find install image %s\n", file);
 	return ISOMD5SUM_CHECK_NOT_FOUND;
     }
 
-- 
1.6.6.1

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux