Re: [PATCH 2/3] Filter UI do not start / stop BIOS RAID sets to get there size (#574587)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ok for f13-branch. I hope it has been tested.

On Thu, 2010-03-18 at 12:00 +0100, Hans de Goede wrote:
> Do not start / stop BIOS RAID sets to get there size, this causes
> issues with BIOS RAID 5 sets as these are not supported by device mapper
> raid in the kernel. Despite this we should still show them (and certainly not
> traceback as we do now) as Intel RAID5 sets will work fine (they use mdraid
> except for in the filter UI).
> ---
>  iw/filter_gui.py |    9 ++-------
>  1 files changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/iw/filter_gui.py b/iw/filter_gui.py
> index 968fe70..d6f0263 100644
> --- a/iw/filter_gui.py
> +++ b/iw/filter_gui.py
> @@ -666,11 +666,8 @@ class FilterWindow(InstallWindow):
>          if flags.dmraid:
>              used_raidmembers = []
>              for rs in block.getRaidSets():
> -                rs.activate(mknod=True, mkparts=False)
> -                udev_settle()
> -
> -                partedDevice = rs.PedDevice
> -                size = int(partedDevice.getSize())
> +                # dmraid does everything in sectors
> +                size = (rs.rs.sectors * 512) / (1024.0 * 1024.0)
>                  fstype = ""
>  
>                  # get_members also returns subsets with layered raids, we only
> @@ -695,8 +692,6 @@ class FilterWindow(InstallWindow):
>                           str(size) + " MB", "", "", "", "", "", "", "", "")
>                  _addTuple(tuple)
>  
> -                rs.deactivate()
> -
>              unused_raidmembers = []
>              for d in raids:
>                  if udev_device_get_name(d) not in used_raidmembers:


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux