-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/19/2010 04:05 AM, Hans de Goede wrote: > + > + import storage > + if isinstance(d, storage.devices.NetworkStorageDevice): > + s = args.append(self.anaconda.network.dracutSetupString(d)) > + if s not in args: > + args.append(s) I think this bit should just be: args.append(self.anaconda.network.dracutSetupString(d)) args.append() doesn't return anything, so no need to assign it, and even if it did, you just appended it to args :) The rest looks good, although the core loop of the get method could probably be rewritten as a " ".join() What are your thoughts on imports inside of methods? I see the import storage was there previously, but in general I like imports at the top of the module so I can keep track of what gets used and what's already available for the module as a whole. Python will only evaluate the import once, but it seems inefficient to have it inside a loop like that. - -- Brian C. Lane <bcl@xxxxxxxxxx> Red Hat / Port Orchard, WA -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEVAwUBS6Os7RF+jBaO/jp/AQL07Af8Dzyq/XZBjL7vXpxR8bmcZtxQDFrFbTy/ xloo1DZCSeHdIc3qeKPvj8wDhi5ZXHOtXpRRAsTKTNG/SFXWIbWLPNcExtgEmUxq wAkSj704Kp+Cd4j6goijVBs2KUEznhyGqImQ4GExQQRVo8sPAnqB92GvQYiZnK9I omgo+F8nEvvD40u2+MmCs7mMkjfm72gchpHjkkArFcIsu+y2HlDRJaIJ6cHHNrDj MRSWww19P/LTi3XI6yE7DcBvlpSMmf49ZwZBmFoUoAFjyRnk4LdDRGtwKh3kSYqO dH+EYVJ7sJKaNqsI1i/wLiXi48+z4DI8jSIX2UlnLe4k3CcP1Y8ykA== =sMrQ -----END PGP SIGNATURE----- _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
