Hi, On 03/19/2010 02:57 PM, Chris Lumens wrote:
diff --git a/iw/filter_gui.py b/iw/filter_gui.py index 136a3e7..2f9a85a 100644 --- a/iw/filter_gui.py +++ b/iw/filter_gui.py @@ -663,7 +663,7 @@ class FilterWindow(InstallWindow): udev_device_get_serial(d), ident, "", "", "", "") _addTuple(tuple) - if flags.dmraid: + if raids and flags.dmraid: used_raidmembers = [] for rs in block.getRaidSets(): # dmraid does everything in sectors @@ -675,12 +675,17 @@ class FilterWindow(InstallWindow): members = filter(lambda m: isinstance(m, block.device.RaidDev), list(rs.get_members())) members = map(lambda m: m.get_devpath(), members) - used_raidmembers.extend(members) for d in raids: if udev_device_get_name(d) in members: fstype = udev_device_get_format(d) break + # Skip this set if none of its members are in the raids list + if not fstype: + continue + + used_raidmembers.extend(members) + # biosraid devices don't really get udev data, at least not in a # a way that's useful to the filtering UI. So we need to fake # that data now so we have something to put into the store.Is this a replacement for patch #3 in your series from yesterday?
Yes it is, sorry I wasn't more clear about that.
If so, ACK. Thanks for making the change - I like this much better.
You're welcome and thanks for the review. Regards, Hans _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
