Re: [PATCH 3/3] BIOS RAID sets get shown double when adding advanced storage (#574714)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> FilterWindow.populate() will scan for BIOS RAID sets and add them on
> every invocation. This causes them to be added multiple times if
> FilterWindow.populate() get called multiple times. This happens for
> example when adding an iSCSI target using the "add Advanced target"
> button on a machine which has a BIOS RAID set.

NAK two different ways:

(1) Magic parameters for telling which time we're running something
always bug me, even if we absolutely have to do it because there's no
other choice.

(2) In _add_advanced_clicked, you will see a bunch of caching of device
names before the call to populate.  The result of this is that populate
should only be called with new devices - those that have shown up since
last time populate was called.  If you're seeing things getting added
twice, it's because there's a bug somewhere in that handling.  We
shouldn't need to introduce anything new to fix this.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux