Re: [PATCH 1/2] Drop iscsi initrd generation hack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-03-05 at 10:38 +0100, Hans de Goede wrote:
> Drop iscsi initrd generation hack, it is not longer needed now that the
> kernel.spec does initrd generation with %posttrans

> -        # See if we have an iscsi disk. If we do we rerun mkinitrd, as
> -        # the initrd might need iscsi-initiator-utils, and chances are
> -        # it was not installed yet the first time mkinitrd was run, as
> -        # mkinitrd does not require it.
> -        root = anaconda.storage.rootDevice
> -        disks = anaconda.storage.devicetree.getDevicesByType("iscsi")
> -        for disk in disks:
> -            if root.dependsOn(disk):
> -                has_iscsi_disk = True
> -                break
> -

This only works if the install is guaranteed to happen in the same
transaction. As we have discussed elsewhere, this is only true if you
have a single media of whatever type and the package layout is
consistent. I'm sure this is probably fine, but before lots of this
happens it might be worth codifying what guarantee of transactions and
ordering is actually being given.

For example, if Anaconda will always undertake to install "certain
kernel related stuff from this comps group" at the same time, and if the
comps are smart enough to have the media laid out just right, cool. If
however, this might break on CD installs because ordering could randomly
change, then, not so cool.

Jon.


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux