Re: [PATCH] Change udev_trigger block calls to use change action instead of add

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-03-03 at 16:44 -0800, Brian C. Lane wrote:
> This fixes bug #569373, where exiting the filter screen would leave the
> /dev/dm-7 and /dev/dm-7 devices missing. It appears that device-mapper
> is removing the devices when udevadm trigger --action=add
> /class/block/dm-0 is run.

Looks good to me.

> ---
>  iw/filter_gui.py |    4 ++--
>  kickstart.py     |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/iw/filter_gui.py b/iw/filter_gui.py
> index 0594712..3d553c7 100644
> --- a/iw/filter_gui.py
> +++ b/iw/filter_gui.py
> @@ -416,7 +416,7 @@ class FilterWindow(InstallWindow):
>          if not addDrive(self.anaconda):
>              return
>  
> -        udev_trigger(subsystem="block")
> +        udev_trigger(subsystem="block", action="change")
>          new_disks = filter(udev_device_is_disk, udev_get_block_devices())
>          (new_singlepaths, new_mpaths, new_partitions) = identifyMultipaths(new_disks)
>          (new_raids, new_nonraids) = self.split_list(lambda d: isRAID(d) and not isCCISS(d),
> @@ -538,7 +538,7 @@ class FilterWindow(InstallWindow):
>                                     gobject.TYPE_STRING)
>          self.store.set_sort_column_id(MODEL_COL, gtk.SORT_ASCENDING)
>  
> -        udev_trigger(subsystem="block")
> +        udev_trigger(subsystem="block", action="change")
>          # So that drives onlined by these show up in the filter UI
>          storage.iscsi.iscsi().startup(anaconda.intf)
>          storage.fcoe.fcoe().startup(anaconda.intf)
> diff --git a/kickstart.py b/kickstart.py
> index 7a00921..36908d0 100644
> --- a/kickstart.py
> +++ b/kickstart.py
> @@ -1208,7 +1208,7 @@ def parseKickstart(anaconda, file):
>      ksparser = AnacondaKSParser(handler)
>  
>      # We need this so all the /dev/disk/* stuff is set up before parsing.
> -    udev_trigger(subsystem="block")
> +    udev_trigger(subsystem="block", action="change")
>      # So that drives onlined by these can be used in the ks file
>      storage.iscsi.iscsi().startup()
>      storage.fcoe.fcoe().startup()


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux