On Fri, 2010-01-15 at 16:53 -0500, Peter Jones wrote:
> On 01/15/2010 04:46 PM, David Lehman wrote:
> > On Fri, 2010-01-15 at 16:23 -0500, Peter Jones wrote:
> >> Create is the right thing to call here; we need it to do things like set
> >> self.exists and do createParents(). Also revamp MultipathDevice.status
> >> since we now can create it in realtime like everything else does.
> >
> > This really isn't what create is for. If all the metadata is there and
> > all you're doing is assembling it into an mpath device, that's setup.
> > Create is for the process of writing the metadata to the member devices.
>
> Hrm. But there things all over the tree that test e.g. self.exists (among
> other things), which only get set if StorageDevice.create() ever gets called.
When you find a device that exists you should instantiate the FooDevice
with exists=True.
Dave
>
> Would you rather I call it setup, call setup, and have setup call
> StorageDevice.create?
>
> >
> > Dave
> >
> >> ---
> >> storage/devices.py | 9 ++++++++-
> >> storage/devicetree.py | 2 +-
> >> 2 files changed, 9 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/storage/devices.py b/storage/devices.py
> >> index 8d74fa7..e350053 100644
> >> --- a/storage/devices.py
> >> +++ b/storage/devices.py
> >> @@ -2973,7 +2973,14 @@ class MultipathDevice(DMDevice):
> >>
> >> @property
> >> def status(self):
> >> - return self._isUp
> >> + """ The device's status (True means active). """
> >> + if not self.exists:
> >> + return False
> >> +
> >> + if not os.path.exists(self.path):
> >> + return False
> >> +
> >> + return True
> >>
> >> @property
> >> def wwid(self):
> >> diff --git a/storage/devicetree.py b/storage/devicetree.py
> >> index 1c241ab..82f6686 100644
> >> --- a/storage/devicetree.py
> >> +++ b/storage/devicetree.py
> >> @@ -1914,7 +1914,7 @@ class DeviceTree(object):
> >> # upon them.
> >> for mp in self.__multipaths.values():
> >> log.info("adding mpath device %s" % mp.name)
> >> - mp.setup()
> >> + mp.create()
> >> self._addDevice(mp)
> >>
> >> # Now, loop and scan for devices that have appeared since the two above
> >
> >
> > _______________________________________________
> > Anaconda-devel-list mailing list
> > Anaconda-devel-list@xxxxxxxxxx
> > https://www.redhat.com/mailman/listinfo/anaconda-devel-list
>
>
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
