Hi, Thanks for the review. On 01/13/2010 09:24 PM, Chris Lumens wrote:
diff --git a/pykickstart/base.py b/pykickstart/base.py index aa4e9d8..3c1237a 100644 --- a/pykickstart/base.py +++ b/pykickstart/base.py @@ -157,7 +157,9 @@ class KickstartCommand(KickstartObject): # useful to call this from KickstartCommand subclasses that handle lists # of objects (like partitions, network devices, etc.) and need to populate # a Data object. - def _setToObj(self, optParser, opts, obj): + def _setToObj(self, optParser, opts, obj, lineno=None): + if lineno: + obj.lineno = lineno for key in filter (lambda k: getattr(opts, k) != None, optParser.keys()): setattr(obj, key, getattr(opts, key))I'm not really sure I like _setToObj doing this. If you look at the comment above it, it's really just meant for copying things from optParser to obj. This overloading doesn't really seem to fit. I don't have a better suggestion than setting lineno manually after calling _setToObj in the rest of this patch.@@ -431,13 +433,14 @@ class BaseData(KickstartObject): removedAttrs = [] def __init__(self, *args, **kwargs): - """Create a new BaseData instance. There are no attributes.""" + """Create a new BaseData instance. The only attribute is lineno."""Even though it's entirely obvious, please make this comment look like the rest of the docs strings in pykickstart.
Ok new version with both comments addressed coming up. Regards, Hans _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
