Re: [PATCH] kickstart.py: Fix undefined reference to handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Instead of using self.handler, which is not defined for
> BaseData derived classes, always use anaconda.id.ksdata in the execute()
> method of pykickstart command/data derived classes.
> ---
>  kickstart.py |   30 +++++++++++++++---------------
>  1 files changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/kickstart.py b/kickstart.py
> index b6cd095..2b4d079 100644
> --- a/kickstart.py
> +++ b/kickstart.py
> @@ -198,7 +198,7 @@ class AutoPart(commands.autopart.F12_AutoPart):
>              anaconda.id.storage.autoPartAddBackupPassphrase = \
>                  self.backuppassphrase
>  
> -        self.handler.skipSteps.extend(["partition", "zfcpconfig", "parttype"])
> +        anaconda.ksdata.skipSteps.extend(["partition", "zfcpconfig", "parttype"])
>  

Your commit message says anaconda.id.ksdata, yet your patch uses
anaconda.ksdata.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux