Re: [PATCH] Fixup various errors detected by pylint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 01/12/2010 10:42 PM, Chris Lumens wrote:
These are going to need to go into rhel6-branch as well, once we've got
that opened back up.

diff --git a/platform.py b/platform.py
index d5c1e68..4b65198 100644
--- a/platform.py
+++ b/platform.py
@@ -466,7 +466,7 @@ class Sparc(Platform):
      @property
      def minimumSector(self, disk):
          (cylinders, heads, sector) = disk.device.biosGeometry
-        start = long(sectors * heads)
+        start = long(sector * heads)
          start /= long(1024 / disk.device.sectorSize)
          return start+1


I'd prefer you rename it from "sector" to "sectors" in the tuple.


Good call, fixed in my local tree. I'll push these to both
branches once the whole rhel6 branch rebase thingie is done.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux