On Tue, 2010-01-12 at 21:57 +0100, Hans de Goede wrote: > > diff --git a/storage/devicetree.py b/storage/devicetree.py > > index 82b7418..2c509b1 100644 > > --- a/storage/devicetree.py > > +++ b/storage/devicetree.py > > @@ -1658,11 +1674,14 @@ class DeviceTree(object): > > # Now, if the device is a disk, see if there is a usable disklabel. > > # If not, see if the user would like to create one. > > # XXX ignore disklabels on multipath or biosraid member disks > > - if device.partitionable and not \ > > - (udev_device_is_biosraid(info) or > > - udev_device_is_multipath_member(info)): > > + if ((device.partitionable and not \ > > + (udev_device_is_biosraid(info) or > > + udev_device_is_multipath_member(info))) or > > + not device.partitionable): > > It took me a while to parse this, I think this comes down to: > > if not udev_device_is_biosraid(info) and not udev_device_is_multipath_member(info): Haha, yes -- yes it does. Thanks for noticing. Dave > > > > self.handleUdevDiskLabelFormat(info, device) > > - if device.partitioned or self.isIgnored(info): > > + if device.partitioned or self.isIgnored(info) or \ > > + (not device.partitionable and > > + device.format.type == "disklabel"): > > # If the device has a disklabel, or the user chose not to > > # create one, we are finished with this device. Otherwise > > # it must have some non-disklabel formatting, in which case > > Regards, > > Hans > > _______________________________________________ > Anaconda-devel-list mailing list > Anaconda-devel-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/anaconda-devel-list _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
