Re: [PATCH 2/2] Ask about LVM inconsistencies only in storageinit step.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-01-06 at 13:44 +0100, Radek Vykydal wrote:
> The patch does essentially the same thing as commit for disk initialization
> question. The difference is that when user chooses LVM reinitialization, it is
> done immediately (not as planned action as with disk initialization) so the
> user wouldn't be asked again anyway without the patch (he would be asked if he
> chose to ignore).
> 
> I also made one function more readable in the patch.

The patch looks good.

We should probably either queue reinitializations for both disklabels
and lvm or else do them both immediately. Do we have a reason to handle
them differently?

Dave

> ---
>  cmdline.py            |   10 ++++++++
>  gui.py                |   45 +++++++++++++++++++++++++++++++++++++++
>  storage/__init__.py   |    1 +
>  storage/devicetree.py |   56 ++++++++++++------------------------------------
>  text.py               |   45 +++++++++++++++++++++++++++++++++++++++
>  5 files changed, 115 insertions(+), 42 deletions(-)


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux