Re: [PATCH 3/7] Add a function to get paths to loaded modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +        modName, _ = modline.split(" ", 1)
> 
> "tmp" might be a better name for a temporary variable than "_".

Coming from an SML background, using _ as a temporary name doesn't
bother me at all.  If you wanted to do things in a more pythonic style,
you'd probably do:

   modName = modline.split(" ", 1)[0]

My only other comment would be that it'd be nice to use execWithCapture
here, but because we want the first column of output, it's going to
involve just as much processing.  So, not worth it.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux