Re: [PATCH 1/6] Use glib's implementation of linked lists

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/08/2009 07:36 AM, Martin Sivak wrote:
> ---
>  loader/driverdisk.c |   46 ++++++++--------------------------------------
>  loader/driverdisk.h |   10 +---------
>  loader/loader.c     |    6 +++---
>  3 files changed, 12 insertions(+), 50 deletions(-)
> 
> diff --git a/loader/driverdisk.c b/loader/driverdisk.c
> index 074428e..a8c191d 100644
> --- a/loader/driverdisk.c
> +++ b/loader/driverdisk.c
> @@ -786,49 +786,14 @@ static void getDDFromDev(struct loaderData_s * loaderData, char * dev) {
>      unlink("/tmp/drivers");
>  }
>  
> -/*
> - * Utility functions to maintain linked-list of device names
> - * */

Patches on top of patches is no way to submit or review code. Please
use "git rebase -i" et al to join these with your first patch set, and
resubmit the entire patch set, so that can see what they're actually
doing to the existing code.

-- 
        Peter

For some reason it has always seemed to me that the term software 
engineering contains some very optimistic assumptions about the 
nature of reality.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux