Re: [PATCH 1/2] display reIPL information via lsreipl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> At the end of an installation, display on the terminal where the
> 390 will reboot into.  Note that this uses different code than
> anaconda uses to provide more reliability.

I definitely prefer this to dumping out all the information manually,
both here and in loader.

> diff --git a/iutil.py b/iutil.py
> index f83b002..ecdc196 100644
> --- a/iutil.py
> +++ b/iutil.py
> @@ -1015,6 +1015,15 @@ def reIPL(anaconda, loader_pid):
>      # or a two-item list with errorMessage and rebootInstr (=> shutdown)
>      return message
> 
> +def dumpReIPLFiles ():
> +    if not isS390():
> +        return
> +
> +    try:
> +        execWithRedirect ("lsreipl", [], stdout = "/dev/tty3", stderr = "/dev/tty3", searchPath=1)
> +    except Exception, e:
> +        log.info("dumpReIPLFiles: Caught exception %s", (e,))
> +
>  def resetRpmDb(rootdir):
>      for rpmfile in glob.glob("%s/var/lib/rpm/__db.*" % rootdir):
>          try:

Please don't catch the top-level Exception.  If you are expecting a
specific exception, catch that.  Otherwise, what are you expecting to
happen here?

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux