Re: [PATCH] Make iscsi,etc startup use the iscsi,etc Singletons

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 12/15/2009 04:17 PM, Chris Lumens wrote:
diff --git a/kickstart.py b/kickstart.py
index a1d10c5..adab33a 100644
--- a/kickstart.py
+++ b/kickstart.py
@@ -1206,9 +1206,9 @@ def parseKickstart(anaconda, file):
      # We need this so all the /dev/disk/* stuff is set up before parsing.
      udev_trigger(subsystem="block")
      # So that drives onlined by these can be used in the ks file
-    anaconda.id.storage.iscsi.startup(anaconda.intf)
-    anaconda.id.storage.fcoe.startup(anaconda.intf)
-    anaconda.id.storage.zfcp.startup()
+    storage.iscsi.iscsi().startup()
+    storage.fcoe.fcoe().startup()
+    storage.zfcp.ZFCP().startup()
      # Note we do NOT call dasd.startup() here, that does not online drives, but
      # only checks if they need formatting, which requires zerombr to be known

Any reason you don't want to pass anaconda.intf there?


Because it is None at this moment in time anyways, also we don't pass interface
when calling iscsi.addTarget, fcoe.addSan, etc. so this seemed more consequent.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux