Re: [PATCH 2/2] kickstart: Move onlining of fcoe/iscsi/zfcp devices to parse phase

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Bring fcoe/iscsi/zfcp devices online when parsing the kickstart file
> (instead of delaying this to the execute phase) so that the disks
> can be identified by /dev/disk/by-path/foo, etc. in clearpart, ignoredisks,
> etc. commands.
> 
> For the iscsi command this also improves error handling by passing
> username and password to addTarget as is instead of only passing them if
> both are present, using addTarget's error handling for a username without
> a password (instead of simply ignoring the username or the password), and
> also by catching IOErrors which will be thrown when logging in to the target
> fails.
> ---
>  kickstart.py |   72 ++++++++++++++++++++++++++++++---------------------------
>  1 files changed, 38 insertions(+), 34 deletions(-)

Assuming you've tested this, it looks okay to me.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux