Hi,
As you already mentioned yourself, my proposal from earlier today
how to handle udevsettle timeouts in general is a more complete
solution for issues like this, so please do not push
this patch. I'll write a patch with my suggested solution soon.
In the mean time I'll add a comment to the bug in question
with an updates.img with my fix (in a crude form) in it.
Regards,
Hans
On 12/09/2009 05:42 PM, Ales Kozumplik wrote:
This is because a case with LVM devices on ATA disks was found where it took up
to 35 seconds for udev to settle.
---
baseudev.py | 2 +-
storage/udev.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/baseudev.py b/baseudev.py
index d88d7fc..bf8cd0f 100644
--- a/baseudev.py
+++ b/baseudev.py
@@ -86,7 +86,7 @@ def udev_parse_uevent_file(dev):
def udev_settle(timeout=None):
argv = ["settle"]
- if timeout:
+ if timeout is not None:
argv.append("--timeout=%d" % int(timeout))
iutil.execWithRedirect("udevadm", argv, stderr="/dev/null", searchPath=1)
diff --git a/storage/udev.py b/storage/udev.py
index 5d4c778..142e20b 100644
--- a/storage/udev.py
+++ b/storage/udev.py
@@ -77,7 +77,7 @@ def udev_resolve_glob(glob):
return ret
def udev_get_block_devices():
- udev_settle(timeout=30)
+ udev_settle(timeout=40)
entries = []
for path in udev_enumerate_block_devices():
entry = udev_get_block_device(path)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
