> When using the entire disk, whole-disk formats are replaced with a > new disklabel. When replacing existing linux installations, linux- > native whole-disk formats are replaced with a new disklabel. Disks > containing whole-disk formatting are not offered as bootloader > installation targets. This looks like a reasonable plan to me. > diff --git a/iw/autopart_type.py b/iw/autopart_type.py > index fc0e4be..c0dfcd8 100644 > --- a/iw/autopart_type.py > +++ b/iw/autopart_type.py My storage patches basically reduce autopart_type.py down to just listing the types of layouts (all, linux, free space, custom) and a checkbox for encrypted by default, which means we're going to have a serious conflict on this chunk. But if you get your patches done first, I guess I can be the one to adapt. > diff --git a/iw/partition_ui_helpers_gui.py b/iw/partition_ui_helpers_gui.py > index ee6d0ac..2f05a6e 100644 > --- a/iw/partition_ui_helpers_gui.py > +++ b/iw/partition_ui_helpers_gui.py > @@ -166,10 +166,11 @@ def createAllowedDrivesStore(disks, reqdrives, drivelist, selectDrives=True, > > def createAllowedDrivesList(disks, reqdrives, selectDrives=True, disallowDrives=[]): > store = gtk.TreeStore(gobject.TYPE_BOOLEAN, > - gobject.TYPE_STRING, > - gobject.TYPE_STRING, > - gobject.TYPE_STRING) > - drivelist = WideCheckList(3, store) > + gobject.TYPE_STRING, > + gobject.TYPE_STRING, > + gobject.TYPE_STRING, > + gobject.TYPE_BOOLEAN) > + drivelist = WideCheckList(3, store, sensitivity=True) > createAllowedDrivesStore(disks, reqdrives, drivelist, selectDrives=selectDrives, > disallowDrives=disallowDrives) WideCheckList? Seems silly to have two classes where the only real difference is in the width of the checkbox field. I know it's not related to your patches, but it might be nice to reduce that whole class down to an argument to CheckList.__init__. Everything else looks fine. - Chris _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
