Hi,
One small nitpick.
On 12/02/2009 10:30 PM, Chris Lumens wrote:
Running anaconda from the command line has only ever been halfway supported
or functional. Now with test mode and rootPath modes gone, running from the
command line doesn't make any sense. So, catch this case and exit.
---
anaconda | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/anaconda b/anaconda
index ed72947..4aa002a 100755
--- a/anaconda
+++ b/anaconda
@@ -642,9 +642,19 @@ if __name__ == "__main__":
(opts, args) = parseOptions()
+ try:
+ parent = os.path.realpath("/proc/%s/exe" % os.getppid())
+ except:
+ parent = "/sbin/loader"
+
if opts.unsupportedMode:
stdoutLog.error("Running anaconda in %s mode is no longer supported." % opts.unsupportedMode)
sys.exit(0)
+ elif not opts.liveinst or not parent.endswith("/loader"):
+ stdoutLog.error("Running anaconda from the command line is not supported.\n"
+ "Please start anaconda either from the boot media or from "
+ "the livecd environment.")
+ sys.exit(0)
# Now that we've got arguments, do some extra processing.
instClass = getInstClass()
I don't see the new if block as being exclusive to the opts.unsupportedMode if, therefor
it should be just an if not an elif. But that might just be my preference.
Other then that this entire patch set is a huge +1, please commit (with or without the elif
changed).
I wonder can we also get rid of the setupfilesystems flag stuff ?
Regards,
Hans
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
