> Not sure if I like the upper here, I can understand you want things > like scsi and sata to be upper cased, but for for example > iSCSI or FcOE (not sure if that ever gets returned, I think they both > will just return scsi, which could be considered a problem by itself) > uppercasing them is wrong. I think I'm okay with this for now, as I haven't gotten to testing iSCSI and FcOE yet. Once I get there, I can reconsider what I'm doing with this string. I'm not tied to the idea of uppercasing it - taking the value as-is from udev might be a better plan just to get me out of the business of manipulating more udev data. > Hmm, we may want to consider overriding the bus value returned from > udev when determining the disk type in devicetree.py, so that we can > properly set bus as iSCSI / FCoE / DASD for such disks (I think > udev will return scsi for all of them), assuming this is used > purely for informational purposes. It's purely for informational purposes in my patches, but I can't speak to what crazy new things we'll come up for in the future. Anyway, setting the bus type in devicetree.py won't help the filtering. There's no DeviceTree object populated when this code runs. It has to operate completely on udev dicts. Of course, we can still add this overriding in to help out later on, should we use the bus attribute on Devices at some point. - Chris _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
