> +class F13_FcoeData(F12_FcoeData): Please add this right here: removedKeywords = F12_FcoeData.removedKeywords removedAttrs = F12_FcoeData.removedAttrs > + def __init__(self, *args, **kwargs): > + F12_FcoeData.__init__(self, *args, **kwargs) > + self.dcb = kwargs.get("dcb", False) Do you also need to update the __eq__ method to take self.dcb into account? > +class F13_Fcoe(F12_Fcoe): Same thing for removed{Keywords,Attrs} here. There's no tests/commands/fcoe.py, but if you would like to add a test case, I'll gladly take it. Also, note that there's an Fcoe class in anaconda/kickstart.py that will need to be updated to subclass commands.fcoe.F13_Fcoe, and that we will need to build the updated anaconda and pykickstart on the same day. - Chris _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list