Re: [PATCH 3/3] Enhance drive specification for clearpart, ignoredisk, and partition.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2009-11-20 at 09:42 -0500, Chris Lumens wrote:
> > Wait -- aren't you setting all of those Storage attributes that should
> > be lists of either Device instances or device names to instead be lists
> > of udev info dicts? I don't think that's gonna work.
> 
> No, I don't think I am.  Everything in this patch adds the return value
> of udev_resolve_glob or udev_resolve_devspec to a list, and those both
> appear to return names:

You're right -- I was just remembering it wrong and didn't check on it.

Dave

> 
> def udev_resolve_glob(glob):
>    ...
>    for dev in udev_get_block_devices():
>       name = udev_device_get_name(dev)
>       if fnmatch.fnmatch(name, glob):
>          ret.append(name)
>    ...
> 
> def udev_resolve_devspec(devspec):
>    ...
>     if ret:
>         return udev_device_get_name(ret)
> 
> Maybe one has slipped through somewhere, though?
> 
> - Chris
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux