Re: [PATCH] If the device disappeared during DD selection, do not crash (#521189)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> diff --git a/loader2/driverdisk.c b/loader2/driverdisk.c
> index 3a0a13c..0a53b93 100644
> --- a/loader2/driverdisk.c
> +++ b/loader2/driverdisk.c
> @@ -288,6 +288,13 @@ int loadDriverFromMedia(int class, struct loaderData_s *loaderData,
>              char ** part_list = getPartitionsList(device);
>              int nump = 0, num = 0;
>  
> +	    /* if somebody removed the drive, partition list is NULL */
> +	    /* rhbz#521189 */
> +	    if (!part_list){
> +              stage = DEV_DEVICE;
> +	      break;
> +	    }
> +
>              if (part != NULL) free(part);
>  
>              if ((nump = lenPartitionsList(part_list)) == 0) {

There's not really any need to reference bug numbers in the code
anymore, since we're putting the numbers in the commit messages and you
can cross reference things that way.  Not that it does any harm, I'm
just saying.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux