On 11/12/2009 01:40 PM, Martin Sivak wrote:
I would test the return code of doPwMount for more than just mounted/not mounted values. If the cdrom is present but cannot be mounted for some reason, we would end up uselessly waiting in the for loop. The RHEL5 variant had kudzu check for the cdrom device, so no problem there. Martin
The problem here is that doPwMount doesn't return anything really useful. On master it calls the system 'mount' command. What I am going to is introduce more IMOUNT_ error codes there and return them accordingly from the function, then use it in the new sleeping code and make sure all the other places doing the mount call do not regress. If someone doesn't like it I'm open to suggestions.
Ales _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
