Re: [PATCH] Set boot flag for /boot on mdraid 1 array too (#533533).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 11/10/2009 02:57 PM, Radek Vykydal wrote:
---
  storage/__init__.py |   17 ++++++++++++-----
  1 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/storage/__init__.py b/storage/__init__.py
index 70c3227..4e911ed 100644
--- a/storage/__init__.py
+++ b/storage/__init__.py
@@ -281,13 +281,20 @@ class Storage(object):
          # now set the boot partition's flag
          try:
              boot = self.anaconda.platform.bootDevice()
+            if boot.type == "mdarray":
+                bootDevs = [self.devicetree.getDeviceByName(x) for x in
+                            self.anaconda.id.bootloader.getPhysicalDevices(boot.name)]

Why not just use boot.parents ? The getPhysicalDevices() thingy in booty is a leftover
from older times, which one day we should get rid of, not use more often :)


+            else:
+                bootDevs = [boot]
          except DeviceError:
-            boot = None
+            bootDevs = []
          else:
-            if hasattr(boot, "bootable"):
-                boot.bootable = True
-                boot.disk.setup()
-                boot.disk.format.commitToDisk()
+            for dev in bootDevs:
+                if hasattr(dev, "bootable"):
+                    log.info("setting boot flag on %s" % dev.name)
+                    dev.bootable = True
+                    dev.disk.setup()
+                    dev.disk.format.commitToDisk()


Other then that it looks good.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux