Re: [PATCH 4/4] Honor existing RUNKS conf file variable on s390 (#513951).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 9 Nov 2009, Jeremy Katz wrote:

On Mon, Nov 9, 2009 at 6:47 PM, David Cantrell <dcantrell@xxxxxxxxxx> wrote:
The linuxrc.s390 rewrite changed the behavior of RUNKS on RHEL-5.  We've
done away with RUNKS on RHEL-6, but we still need to maintain existing
functionality on RHEL-5.

To minimize the deltas between RHEL5 and RHEL6, would it make sense to
just have something like
 if [ "$RUNKS" = "0" ]; then RUNKS="" ; fi
at the top of the script?

Looks fine in any case, just minor nitpicking to save effort on
keeping the two in sync.

Yeah, how about:

- ---
 loader2/linuxrc.s390 |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/loader2/linuxrc.s390 b/loader2/linuxrc.s390
index 5dec01d..2856f96 100644
- --- a/loader2/linuxrc.s390
+++ b/loader2/linuxrc.s390
@@ -52,6 +52,10 @@ unset testing
 # uncomment the following test="1" to never execute sensitive commands
 #testing="1"

+if [ "$RUNKS" = "0" ]; then
+    RUNKS=""
+fi
+
 # helper function to disable commands while running outside the initrd
 function tv() {
     if [ -z "$testing" ]; then
- -- 1.6.5.2

Woo.

- -- David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkr40nMACgkQ5hsjjIy1Vkn9FwCfUBWgXmoLM+jvcWiBOwwtOvJ/
PmkAoIqpZH/wbe1dhpXT14E+8wjykBCe
=KA1Q
-----END PGP SIGNATURE-----
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux