Re: [PATCH] DASD disklabels do not allow sector exact partitioning (#527104)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 28 Oct 2009, Hans de Goede wrote:

Hi,

On 10/27/2009 09:06 PM, David Cantrell wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 27 Oct 2009, Hans de Goede wrote:

---
storage/partitioning.py | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/storage/partitioning.py b/storage/partitioning.py
index 1e2ee40..a5edd22 100644
--- a/storage/partitioning.py
+++ b/storage/partitioning.py
@@ -858,7 +858,11 @@ def allocatePartitions(disks, partitions):
partition = parted.Partition(disk=disklabel.partedDisk,
type=part_type,
geometry=new_geom)
- constraint = parted.Constraint(maxGeom=max_geom, minGeom=min_geom)
+ # DASD disklabels do not allow sector exact partitioning (#527104)
+ if _disk.type != 'dasd':
+ constraint = parted.Constraint(maxGeom=max_geom, minGeom=min_geom)
+ else:
+ constraint = disklabel.partedDevice.getConstraint()
disklabel.partedDisk.addPartition(partition=partition,
constraint=constraint)
log.debug("created partition %s of %dMB and added it to %s" %


Make sure this is applied to master as well as rhel6-branch.


I discussed this with dlehman and master will get the code in question
completely replaced by new partitioning code within the next few days,
so this patch only went to the rhel6-branch.


Sounds good.  So long as master is not forgotten.

- -- David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkrooxkACgkQ5hsjjIy1VkmY2wCgvyaFfVIDoEZmpOACD35hl2/h
qKgAnRoebqCSrPdAzheeYiiPWwMvCqSh
=CQBz
-----END PGP SIGNATURE-----

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux