Sorry, I forgot one thing on my initial reply.
On 10/27/2009 05:24 PM, Steffen Maier wrote:
> On 10/27/2009 03:07 AM, David Cantrell wrote:
>> Before the device tree is built in the storage code, run through the
>> DASD devices on the system and format any with a status of
>> 'unformatted'. We have to run dasdfmt on these devices before we can
>> partition them.
>>
>> Under RHEL-5, this process was serial and the user had to click Yes for
>> each unformatted DASD found, which could take a really long time if
>> you had thousands of DASDs.
>>
>> The idea now is that if the DASD is seen by anaconda, we want to use it
>> for installation. The stage 1 device initialization routines as well as
>> the CMS conf file provided at boot time allow the user to restrict the
>> range of devices we see during installation. If any of the devices we
>> see are unformatted, run dasdfmt before building the devicetree.
>>
>> This process is implemented in a DASD class that works similar to the
>> iscsi and zfcp classes. That is, devices may need to be started or
>> brought in to a working state before the anaconda storage code can use
>> them.
>> ---
>> storage/__init__.py | 3 +
>> storage/dasd.py | 167 +++++++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 170 insertions(+), 0 deletions(-)
>> create mode 100644 storage/dasd.py
>> diff --git a/storage/dasd.py b/storage/dasd.py
>> new file mode 100644
>> index 0000000..f4df8ca
>> --- /dev/null
>> +++ b/storage/dasd.py
>> @@ -0,0 +1,167 @@
>> + log.info(" %s is an unformatted DASD" % (device,))
>> + self._dasdlist.append(device)
>> +
>> + if not len(self._dasdlist):
>> + log.info(" no unformatted DASD devices found")
>> + return
>> +
>> + if intf:
>> + c = len(self._dasdlist)
>> +
>> + title = P_("Unformatted DASD Device Found",
>> + "Unformatted DASD Devices Found", c)
>> + msg = P_("Format uninitialized DASD device?\n\n"
>> + "There is %d uninitialized DASD device on this "
>> + "system. To continue installation, the device must "
>> + "be formatted. Formatting will remove any data on "
>> + "this device. If you are unsure of your DASD "
>> + "configuration, select No to exit the installer." % c,
>> + "Format uninitialized DASD devices?\n\n"
>> + "There are %d uninitialized DASD devices on this "
>> + "system. To continue installation, the devices must "
>> + "be formatted. Formatting will remove any data on "
>> + "these devices. If you are unsure of your DASD "
>> + "configuration, select No to exit the installer." % c,
>> + c)
>> +
>> + rc = intf.messageWindow(title, msg,
>> + custom_icon="error", type="yesno")
>> + if rc == 0:
>> + sys.exit(0)
IIRC, with RHEL5 the user could just ignore unprepared DASDs and
continue with whatever disks would then be left. Since some of the
user-specified DASDs may already be prepared (or zFCP LUNs may be
available), this seems like a valid and user-friendly choice to me.
Could we change the exit into an early return from this method, so the
user could happily continue with installation, if he does not want to
touch the unprepared DASDs?
Steffen
Linux on System z Development
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Erich Baier
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
