Re: [PATCH 2/2] Find and format any unformatted DASD devices (#528386).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +            title = P_("Unformatted DASD Device Found",
> > +                       "Unformatted DASD Devices Found", c)
> > +            msg = P_("Format uninitialized DASD device?\n\n"
> > +                     "There is %d uninitialized DASD device on this "
> > +                     "system.  To continue installation, the device must "
> > +                     "be formatted.  Formatting will remove any data on "
> > +                     "this device.  If you are unsure of your DASD "
> > +                     "configuration, select No to exit the installer." % c,
> > +                     "Format uninitialized DASD devices?\n\n"
> > +                     "There are %d uninitialized DASD devices on this "
> > +                     "system.  To continue installation, the devices must "
> > +                     "be formatted.  Formatting will remove any data on "
> > +                     "these devices.  If you are unsure of your DASD "
> > +                     "configuration, select No to exit the installer." % c,
> > +                     c)
> 
> We should show the list of DASDs to be formatted to the user and not
> just how many. Otherwise he can hardly make a decision whether to
> continue or not. We should have a string of the device bus IDs or simply
> the symlink names under /dev/disk/by-path/ for the DASDs in
> self._dasdlist. This is a similar use case to the one we had a while
> back where we show a dialog box at the end of the partitioner on which
> partitions will be formatted with a file system.

I'd be worried about how that sort of dialog would scale if you have 50
or 100 or 1000 DASDs to be formatted.

> > +
> > +            rc = intf.messageWindow(title, msg,
> > +                                    custom_icon="error", type="yesno")
> > +            if rc == 0:
> > +                sys.exit(0)
> 
> I would like to see an else case here when there is no UI. As Hans
> already pointed out, silently low-level formatting DASDs which do not
> have any known format, is a bit hard. Suppose such DASD has an unknown
> format with important data on it. Then we should not silently format it
> and loose the data. A kickstart command as suggested by Hans sounds good.
> How was this case handled with RHEL5?

We already have clearpart --initlabel.  I'd rather reuse that than add
yet another command or option.  Quick, someone explain how clearpart and
zerombr and all their options work in all cases!

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux