Re: [PATCH - rhel6-branch] Fix translations of timezones in the UI (#530014).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > @@ -163,7 +163,7 @@ class AnacondaTZMap(TimezoneMap):
> >         iter = widget.get_active_iter()
> >         if iter is None:
> >             return
> > -        entry = widget.get_model().get_value(iter, self.columns.ENTRY)
> > +        entry = widget.get_model().get_value(iter, 1)
> 
> Why not use the enum here?  Most of the patch is switching to using
> the self.columns enum but this hunk does the opposite.

I had some problems getting what's in the store lining up with what's in
the enum, and then this patch got pushed by accident due to an
overzealous "git push".

This is a valid complaint, but I think I'd rather go in and remove as
much of the current subclassing as possible and make us just use the
timezone page from s-c-date's notebook instead.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux