Re: [PATCH 1/3] Do not translate exception messages in storage/zfcp.py.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/20/2009 02:51 AM, David Cantrell wrote:
> On Sat, 17 Oct 2009, Steffen Maier wrote:
>> Just because in some cases (parm/conf file or kickstart) the messages do
>> not get to the UI and are only logged does not seem to justify removing
>> the translations altogether.
> 
> Yes it does.  We don't want translated messages in the log files simply
> because it makes finding the problem code more difficult.  Translated
> messages for the UI are a different story.

>> commit f13f934cc9a8898b996731fbb950048ba3fbbc6d
>> Author: Steffen Maier <maier@xxxxxxxxxxxxxxxxxx>
>> Date:   Fri Jul 10 10:19:40 2009 -1000
>>
>>    error messages of zFCP on s390: log or pass to the UI
> 
> Looking back at this patch, I forsee problems with us being able to work
> bugs filed by users if translated messages are ending up in the logs.

True. So have each string twice, once without translation and
immediately logging it (and removing the deferred log statements in the
catch statements of ValueError), and once with translation to throw as
ValueError?
If so, can we define each string only once and mark one instance
translatable and one fix so we don't have to copy&paste each string in
two separate copies which may get out of sync?

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Erich Baier
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux