> diff --git a/anaconda b/anaconda
> index 6b01ed0..a3081e2 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -721,6 +721,11 @@ if __name__ == "__main__":
> #
> if earlyKS and not opts.rescue:
> opts.rescue = earlyKS.rescue.rescue
> +
> + # Store the partitioning layout to log in case anything goes wrong
> + PartLayout = iutil.execWithCapture("parted", ["parted", "-l"])
> + log.debug("Partition layout at the beginning of instalation as seen by parted -l:\n" + PartLayout)
> + del PartLayout
>
> if opts.rescue:
> anaconda.rescue = True
This is really early on - even before storage is initialized. Is parted
going to do any crazy probing here that we don't want done?
> diff --git a/exception.py b/exception.py
> index 3493786..eacbf54 100644
> --- a/exception.py
> +++ b/exception.py
> @@ -35,6 +35,12 @@ import logging
> log = logging.getLogger("anaconda")
>
> class AnacondaExceptionHandler(ExceptionHandler):
> + def preWriteHook(self, (ty, value, tb), anaconda):
> + # Store the last known partitioning layout
> + PartLayout = iutil.execWithCapture("parted", ["parted", "-l"])
> + log.debug("Partition layout at the moment of exception as seen by parted -l:\n" + PartLayout)
> + del PartLayout
> +
> def postWriteHook(self, (ty, value, tb), anaconda):
> # See if /mnt/sysimage is present and put exception there as well
> if os.access("/mnt/sysimage/root", os.X_OK):
Ah, good use of preWriteHook. I think you might just be the first
person to make use of it.
Looks okay overall, though I'd prefer "partLayout" to "PartLayout".
Picky, I know.
- Chris
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
