Looks ok,
Regards,
Hans
On 10/12/2009 07:22 PM, Radek Vykydal wrote:
Just update the order of drives instead of using only drives set in
--driveorder option.
F12 material, I think.
Another thing I hit which might cause problems somewhere is that bootloaderInfo
is old-style class, so setting of its property drivelist doesn't work (instead
the property is overwritten with attribute and therefore for example any
following calls of updateDriveList have no effect). Although beside code replaced in
this patch, we are doing it only in one place in bootloaader UI where it
seems harmless, and making bootloaderInfo new-style class will require
modification of bootloader.configfile handling (which relies on bad behavior of
property in bootloaderInfo), I think we should fix it. I'll come with a patch.
---
kickstart.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kickstart.py b/kickstart.py
index 57f7aa3..8029861 100644
--- a/kickstart.py
+++ b/kickstart.py
@@ -257,7 +257,7 @@ class Bootloader(commands.bootloader.F12_Bootloader):
log.warning("requested drive %s in boot drive order "
"doesn't exist" %(drive,))
- self.handler.id.bootloader.drivelist = new
+ self.handler.id.bootloader.updateDriveList(new)
self.handler.permanentSkipSteps.extend(["upgbootloader", "bootloader"])
return retval
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
