Re: [PATCH parted] Handle swap flag in msdos type labels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 10/10/2009 03:41 PM, Jim Meyering wrote:
Hans de Goede wrote:
From: David Cantrell<dcantrell@xxxxxxxxxx>

Original patch by David Cantrell<dcantrell@xxxxxxxxxx>, I
(Hans de Goede<hdegoede@xxxxxxxxxx>) made the following changes:
-msdos_partition_is_flag_available() should return 1 for swap flag
-Only change the partition type to 82 when setting the swap flag
  on dos labels, not when resetting it

Hi Hans,

Thanks to both of you for the patch.

Can you outline a quick test or two to verify the
presence/absence of this fix?


Quite simple, make a msdos label, create a partition, set the swap
flag on it. Without this patch it should fail (haven't actually tested)
as msdos_partition_is_flag_available() returns 0 for the swap flag
and I expect the higher level functions to test this.

With this patch it accepts it, and the type of the created
partition table entry becomes 82 instead of 83.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux