Re: [PATCH] formatByDefault: Don't traceback when mountpoint is None (#522609)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 10/06/2009 03:27 PM, Chris Lumens wrote:
Don't traceback in formatByDefault() when a device with a mountable
format has a mountpoint of None. Instead simply assume that if we don't
mount it anywhere it does not need to be formatted.

This seems more like fixing the symptom than the cause.  How can we end
up in this situation?


In the particular backtrace, from #522609, I dunno,
mountpoint is defined there as:

            mountpoint = self.mountCombo.get_children()[0].get_text()
            if mountpoint:

Which does evil pygtk stuff which I cannot parse, but the

if mountpoint:

Directly below it does suggest the None is expected in some cases.

Note that the default value for mountpoint is None, so my patch is not
as much of a workaround as it seems.

storage/format/fs.py:

class FS(DeviceFormat):

    def __init__(self, *args, **kwargs):

        self.mountpoint = kwargs.get("mountpoint")

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux