On Fri, Oct 02, 2009 at 10:46:58AM -1000, David Cantrell wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Tue, 29 Sep 2009, Joel Granados wrote: > >> On Fri, Sep 25, 2009 at 02:07:29PM -1000, David Cantrell wrote: >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA1 >>> >>> Comments inline. Code looks fine, just some comments on the wording. >>> >>> On Wed, 16 Sep 2009, Joel Granados Moreno wrote: >>> >>>> The message was being munged and it was overly long, grabbing attention >>>> from the drive lists. >>>> * iw/raid_dialog_gui.py (__init__): Reduce message length. Introduce >>>> some padding for the drive lists. The gtk reference suggests to use >>>> set_default_size instead of set_size_request >>>> http://www.pygtk.org/docs/pygtk/class-gtkwindow.html#method-gtkwindow--set-default-size >>>> --- >>>> iw/raid_dialog_gui.py | 33 ++++++++++++--------------------- >>>> 1 files changed, 12 insertions(+), 21 deletions(-) >>>> >>>> diff --git a/iw/raid_dialog_gui.py b/iw/raid_dialog_gui.py >>>> index bb457a5..2e742e5 100644 >>>> --- a/iw/raid_dialog_gui.py >>>> +++ b/iw/raid_dialog_gui.py >>>> @@ -767,8 +767,8 @@ class RaidCloneDialog: >>>> self.parent = parent >>>> >>>> self.dialog = None >>>> - self.dialog = gtk.Dialog(_("Make RAID Device"), self.parent) >>>> - self.dialog.set_size_request(500, 400) >>>> + self.dialog = gtk.Dialog(_("Clone Drive Tool"), self.parent) >>>> + self.dialog.set_default_size(500, 200) >>>> gui.addFrame(self.dialog) >>>> self.dialog.add_button('gtk-cancel', 2) >>>> self.dialog.add_button('gtk-ok', 1) >>>> @@ -776,23 +776,14 @@ class RaidCloneDialog: >>>> >>>> # present list of drives as source >>>> vbox = gtk.VBox() >>>> - >>>> - lbl = gui.WrappingLabel(_("Clone Drive Tool\n\n" >>>> - "This tool allows you to significantly " >>>> - "reduce the amount of effort required " >>>> - "to setup RAID arrays. This tool " >>>> - "uses a source drive which has been " >>>> - "prepared with the desired partitioning " >>>> - "layout, and clones this layout onto other " >>>> - "similar sized drives. Then a RAID device " >>>> - "can be created.\n\n" >>>> - "NOTE: The source drive must have " >>>> - "partitions which are restricted to be on " >>>> - "that drive only, and can only contain " >>>> - "unused software RAID partitions. Other " >>>> - "partition types are not allowed.\n\n" >>>> - "EVERYTHING on the target drive(s) will be " >>>> - "destroyed by this process.")) >>>> + clnmessage = _("This tool clones the layout from a partitioned source " >>>> + "onto other similar sized drives. The source must have " >>> >>> 'similar sized drives' sounds too ambiguous for a user. Do the drives have to be >>> exactly the same size or can they be equal or greater than the source drives? >> >> Note that the message had that ambiguity already. I don't know what >> similar sized drives means. :). I'm guessing that it means drives that >> are at least as big as the one that is being cloned. > > That's my guess to. I suggest we kill the 'similar sized drives' text and > replace it with something more specific. Yep this messages is kinda strange. Lets change it to: """ This tool clones the layout from a partitioned source onto other drives. The source must have partitions which are restricted to that drive and must ONLY contain unused software RAID partitions. The target drive must be at least as big as the source. EVERYTHING on the target drive(s) will be destroyed.\n """ What do you think? > >>>> + "partitions which are restricted to be on that drive " >>> >>> I'd say: >>> >>> "partitions which are restricted to that drive " >> >> yep, this one seems better. >> >>> >>>> + "only, and can ONLY contain unused software RAID " >>>> + "partitions. EVERYTHING on the target drive(s) will " >>> >>> The first sentence says 'drives', so should we say 'drives' here? Will it >> >> The firs is with an 's' because I want to express a type of drive. Its like >> saying black drives or big drives. Here its similar sized drives. >> >>> ever be 'drive'? >> >> Yes. One can choose to clone to one or more drives. > > If the user can choose one or more drive, would we know that number before > bringing up this dialog? I'm a fan of being able to determine if we need to > use singular or plural language programatically rather than saying 'drive(s)'. :), but no. We have no way of knowing this information. We could know the number of possible targets, but its still up to the user to clone to one or more drive(s). > > - -- David Cantrell <dcantrell@xxxxxxxxxx> > Red Hat / Honolulu, HI > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iEYEARECAAYFAkrGZsIACgkQ5hsjjIy1Vkn5CQCeMNddVK7v0+NB31g13O6RzzwO > j0IAmwUJhJmCYCzMAnzYAe0PcJqnNew3 > =AXj4 > -----END PGP SIGNATURE----- > > _______________________________________________ > Anaconda-devel-list mailing list > Anaconda-devel-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/anaconda-devel-list -- Joel Andres Granados Brno, Czech Republic, Red Hat.
Attachment:
pgp9UCjcHurdO.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
