Re: [PATCH 12/14] Fix methodstr editing dialog.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Lumens wrote:
--- a/yuminstall.py
+++ b/yuminstall.py
@@ -318,7 +318,7 @@ class AnacondaYum(YumSorter):
                       "installation repository:\n\n%s\n\nPlease provide the "
                       "correct information for installing %s.") % (e, productName))
- self.anaconda.methodstr = self.anaconda.intf.methodstrRepoWindow()
+                self.anaconda.methodstr = self.anaconda.intf.methodstrRepoWindow(self.anaconda.methodstr or "cdrom:")
self.doConfigSetup(root=anaconda.rootPath)
         self.conf.installonlypkgs = []

See previous comment about whether methodstr vs. "cdrom:" is the only
valid choices you've got.

Here, (reading configBaseURL), either methodstr is True, or local media search failed with SystemError (not very likely?), and "cdrom:" in this case is just used to set
CD/DVD as default in methodstr editing dialog.
Again - it is dependent on configBaseURL code which makes it unreadable and
prone to introduce errors in case of changes.

I even tried to make configBaseURL to return boolean so that methodstr editing
dialog can be raised also in other cases than SystemError exception
(for example failed "cdrom://XXX" methodstr), and to
have all media scans only in configBaseURL, not in _applyMedia of methodstrRepoWindow (which would just guard syntax of methodstr then), but I didn't want to include it in the first set of patches - I had to try to make things work first, and also to
be sure that getting rid of SetupBaseRepo is OK before making changes in
configBaseURL. It's complicated :(.

Radek

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux