[PATCH] Improve loader messages in parseCmdLineFlags when passing vnc (#526350).

[Steffen Maier <maier@xxxxxxxxxxxxxxxxxx>]

Instead of the misleading
21:55:23 INFO : vnc forced cmdline mode from cmdline
21:55:23 INFO : early networking required for syslog
it now prints correctly
21:55:23 INFO : vnc forced graphical mode from cmdline
21:55:23 INFO : early networking required for vnc

The early networking message was introduced solely for syslog in
620bdb978bfe46f96f04865e776edd15728b85d8
but later reused without adaptation also for vnc in
b27dcdc6a37b5429b50579dbf0650e880a95988c.
---
 loader/loader.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/loader/loader.c b/loader/loader.c
index e44240a..c8c587b 100644
--- a/loader/loader.c
+++ b/loader/loader.c
@@ -1106,7 +1106,7 @@ static void parseCmdLineFlags(struct loaderData_s * loaderData,
 
                 /* vnc implies graphical */
                 if (!strncasecmp(argv[i], "vnc", 3)) {
-                    logMessage(INFO, "vnc forced cmdline mode from cmdline");
+                    logMessage(INFO, "vnc forced graphical mode from cmdline");
                     flags |= LOADER_FLAGS_GRAPHICAL;
                 }
 
@@ -1117,7 +1117,8 @@ static void parseCmdLineFlags(struct loaderData_s * loaderData,
                 if (!strncasecmp(argv[i], "syslog", 6) ||
                     !strncasecmp(argv[i], "vnc", 3) ||
                     isKickstartFileRemote(loaderData->ksFile)) {
-                    logMessage(INFO, "early networking required for syslog");
+                    logMessage(INFO, "early networking required for %s",
+                               argv[i]);
                     flags |= LOADER_FLAGS_EARLY_NETWORKING;
                 }
 
-- 
1.6.4.4


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list