Hey David.
I went with your idea of having the 'delete' and 'edit' buttons activate
and deactivate according to what the user selected. With this in mind
this message is no longer needed. I have taken this patch away from the
patch set.
Regards.
On Fri, Sep 25, 2009 at 01:30:01PM -1000, David Cantrell wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Wed, 16 Sep 2009, Joel Granados Moreno wrote:
>
>> * iw/partition_gui.py (editCB): Inform the user the types of editable
>> devices when "edit" is not possible.
>> ---
>> iw/partition_gui.py | 8 ++++++++
>> 1 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/iw/partition_gui.py b/iw/partition_gui.py
>> index 3eaa490..ffdd30b 100644
>> --- a/iw/partition_gui.py
>> +++ b/iw/partition_gui.py
>> @@ -1265,6 +1265,14 @@ class PartitionWindow(InstallWindow):
>> self.editLVMLogicalVolume(device)
>> elif isinstance(device, storage.devices.PartitionDevice):
>> self.editPartition(device)
>> + else:
>> + self.intf.messageWindow(_("Unable to Edit"),
>> + _("You chose a device that cannot be "
>> + "edited. Devices that are editable are: "
>> + "LVM logical volumes, LVM physical "
>> + "volumes, device partitions, and RAID "
>> + "devices."),
>> + custom_icon="error")
>>
>> # isNew implies that this request has never been successfully used before
>> def editRaidArray(self, raiddev, isNew = 0):
>>
>
> The warning looks fine, but I'd reword the message a bit. Something like this
> maybe:
>
> Unable to edit DEVICE. Please select an LVM volume, partition, or RAID
> device.
>
> Just to simplify things a bit.
>
> - -- David Cantrell <dcantrell@xxxxxxxxxx>
> Red Hat / Honolulu, HI
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkq9UnoACgkQ5hsjjIy1Vkn0yACfZ9KQW3fpvUA+sSzu81MmmJSg
> Y4MAn0E8eW35jyuQSXGzKYoLWmyn5620
> =2Cgp
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
--
Joel Andres Granados
Brno, Czech Republic, Red Hat.
Attachment:
pgpqPiFSB7u6z.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
