-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Comments inline. Code looks fine, just some comments on the wording.
On Wed, 16 Sep 2009, Joel Granados Moreno wrote:
The message was being munged and it was overly long, grabbing attention
from the drive lists.
* iw/raid_dialog_gui.py (__init__): Reduce message length. Introduce
some padding for the drive lists. The gtk reference suggests to use
set_default_size instead of set_size_request
http://www.pygtk.org/docs/pygtk/class-gtkwindow.html#method-gtkwindow--set-default-size
---
iw/raid_dialog_gui.py | 33 ++++++++++++---------------------
1 files changed, 12 insertions(+), 21 deletions(-)
diff --git a/iw/raid_dialog_gui.py b/iw/raid_dialog_gui.py
index bb457a5..2e742e5 100644
--- a/iw/raid_dialog_gui.py
+++ b/iw/raid_dialog_gui.py
@@ -767,8 +767,8 @@ class RaidCloneDialog:
self.parent = parent
self.dialog = None
- self.dialog = gtk.Dialog(_("Make RAID Device"), self.parent)
- self.dialog.set_size_request(500, 400)
+ self.dialog = gtk.Dialog(_("Clone Drive Tool"), self.parent)
+ self.dialog.set_default_size(500, 200)
gui.addFrame(self.dialog)
self.dialog.add_button('gtk-cancel', 2)
self.dialog.add_button('gtk-ok', 1)
@@ -776,23 +776,14 @@ class RaidCloneDialog:
# present list of drives as source
vbox = gtk.VBox()
-
- lbl = gui.WrappingLabel(_("Clone Drive Tool\n\n"
- "This tool allows you to significantly "
- "reduce the amount of effort required "
- "to setup RAID arrays. This tool "
- "uses a source drive which has been "
- "prepared with the desired partitioning "
- "layout, and clones this layout onto other "
- "similar sized drives. Then a RAID device "
- "can be created.\n\n"
- "NOTE: The source drive must have "
- "partitions which are restricted to be on "
- "that drive only, and can only contain "
- "unused software RAID partitions. Other "
- "partition types are not allowed.\n\n"
- "EVERYTHING on the target drive(s) will be "
- "destroyed by this process."))
+ clnmessage = _("This tool clones the layout from a partitioned source "
+ "onto other similar sized drives. The source must have "
'similar sized drives' sounds too ambiguous for a user. Do the drives have to be
exactly the same size or can they be equal or greater than the source drives?
+ "partitions which are restricted to be on that drive "
I'd say:
"partitions which are restricted to that drive "
+ "only, and can ONLY contain unused software RAID "
+ "partitions. EVERYTHING on the target drive(s) will "
The first sentence says 'drives', so should we say 'drives' here? Will it
ever be 'drive'?
+ "be destroyed.\n")
+
+ lbl = gui.WrappingLabel(clnmessage)
vbox.pack_start(lbl)
box = gtk.HBox()
@@ -803,7 +794,7 @@ class RaidCloneDialog:
(sw, self.sourceView) = self.createDriveList(storage.disks)
selection = self.sourceView.get_selection()
selection.set_mode(gtk.SELECTION_SINGLE)
- box.pack_start(sw)
+ box.pack_start(sw, padding=5)
lbl = gtk.Label(_("Target Drive(s):"))
lbl.set_alignment(0.0, 0.0)
@@ -811,7 +802,7 @@ class RaidCloneDialog:
(sw, self.targetView) = self.createDriveList(storage.disks)
selection = self.targetView.get_selection()
selection.set_mode(gtk.SELECTION_MULTIPLE)
- box.pack_start(sw)
+ box.pack_start(sw, padding=5)
frame = gtk.Frame(_("Drives"))
frame.add(box)
- --
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkq9W0EACgkQ5hsjjIy1Vkll5wCdFjB/aKULnc+t3sGht8AXFNGs
PO4AoNF4IhS+MU7vSYc08v//qQlgcVOS
=zrev
-----END PGP SIGNATURE-----
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
