Re: [PATCH 1/5] Add function udev_device_get_lv_attr to retrieve lv attribute strings.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > You could probably still get a KeyError when you look up LVM2_LV_ATTR,
> > right?  So, how about:
> > 
> >    attr = info.get("LVM2_LV_ATTR", [])
> > 
> > to replace the first three lines?  I know you use this idiom in plenty
> > of other places.
> 
> We catch KeyError when we call the function from storage/devicetree.py.
> It's the same as most of the other udev_device_get_foo functions. We do
> that so that it's clear to the caller that something is wrong/missing.

Alright, good.  One day I would still love to see us codify this kind of
thing.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux