Re: [PATCH 4/4] Add 'install' user to start anaconda on s390x.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/18/2009 02:26 AM, David Cantrell wrote:
> This is a usability improvment.  Once you've booted up the kernel and
> initrd on s390x, you are told to ssh in to the host to start the
> installation.  In the past, we had rigged the root account to launch
> loader on the first login and a shell on subsequent logins.  In this
> patch, I've added an 'install' user that has loader for the shell.  The
> root user still has bash for the shell.  Also change the recommendation
> to run 'ssh -X' rather than 'ssh -x'.
> ---
>  loader/linuxrc.s390 |    5 ++---
>  scripts/mk-images   |   10 +++++++---
>  2 files changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/loader/linuxrc.s390 b/loader/linuxrc.s390
> index 53ce90d..c6efbe4 100644
> --- a/loader/linuxrc.s390
> +++ b/loader/linuxrc.s390
> @@ -129,9 +129,8 @@ function startinetd()
>      /sbin/sshd
>      if [ -z "$RUNKS" ]; then
>          echo
> -        echo $"Connect now to $IPADDR and login as user root to start the installation."
> -        echo $"E.g. using: ssh -x root@$IPADDR"
> -        echo $"After login, please start the installation using: loader"
> +        echo $"Connect now to $IPADDR and login as user install to start the installation."
> +        echo $"E.g. using: ssh -X install@$IPADDR"

Hm, I changed this to suggesting disabled X11 forwarding intentionally
not long ago:
http://git.fedorahosted.org/git/anaconda.git?p=anaconda.git;a=commitdiff;h=4414941fc05b68b4b240ab2c567fb31733e04e59
"The GTK used for the GUI in anaconda requires some recent X extensions,
which most probably many clients don't have, so do not suggest using
ssh logins with X11-forwarding but rather suggest explicitly disabled
X11-forwarding so the users may then choose VNC, which works fine."

If you want to suggest enabled X fwd, then you will have to explicitly
document the generic event extension thing in the System z specific part
of the RHEL installation guide because users would certainly fall into
this trap. I would like them not to.

For putty users, they might not even understand "-x" or "-X" so we might
want to make this X fwd thing explicit text here as well.

>          read
>          while : ; do
>              /bin/sh --login
> diff --git a/scripts/mk-images b/scripts/mk-images
> index 26d3a43..68760d1 100755
> --- a/scripts/mk-images
> +++ b/scripts/mk-images
> @@ -408,9 +408,13 @@ instbin() {
>  setupShellEnvironment() {
>      echo "tcp     6       TCP" > $MBD_DIR/etc/protocols
> 
> -    cat > $MBD_DIR/etc/shadow << EOF
> -root::14438:0:99999:7:::
> -EOF
> +    # enable root shell logins
> +    echo "root::14438:0:99999:7:::" >> $MBD_DIR/etc/shadow
> +
> +    # enable 'install' account that starts anaconda on login
> +    echo "install:x:0:0:root:/root:/sbin/loader" >> $MBD_DIR/etc/passwd
> +    echo "install::14438:0:99999:7:::" >> $MBD_DIR/etc/shadow
> +
>      chmod 0400 $MBD_DIR/etc/shadow
> 
>      # PAM configuration

Nice idea. I also liked the fact that I could login and it wouldn't
start loader immediately. While we still have this with root, it is
currently documented nowhere. This should at least go into the install
guide. Telling the user of the root option without automatic
continuation on the screen would also be nice.

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Erich Baier
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux