-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Fri, 18 Sep 2009, Chris Lumens wrote:
Avoid SIGSEGV in addOption() in loader/modules.c. Just because found
does not equal 0 does not mean we found the module requested.
Can you explain what's going on in this patch and function? Got a bug
number?
The other three patches look good.
It's actually related to the first patch where I reduce the mlLoadModuleSet()
call on s390x. When mlLoadModuleSet() was called with floppy, pcspkr, etc on
s390x, the console was getting a backtrace dumped and it fell in to
addOption().
The assumption in addOption() is that the module is always found, which isn't
the case. We can prevent that by only calling mlLoadModuleSet() with modules
that exist on the platform, but in order to prevent these backtraces in the
future, I figured it was worth fixing addOption() too.
https://bugzilla.redhat.com/show_bug.cgi?id=523616
- --
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkqz9IgACgkQ5hsjjIy1VknAZgCdHf8peT7YQjzkizCTbkFl2RJu
Mz8An033RmLml7J/dVimwTsWumZuCrSP
=Hdov
-----END PGP SIGNATURE-----
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
